RFR: 8340404: Clarify CharsetProvider deployment on application module path [v3]
Naoto Sato
naoto at openjdk.org
Thu Sep 19 17:03:02 UTC 2024
On Thu, 19 Sep 2024 16:59:50 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8340412) which clarifies that a CharsetProvider SPI can be provided via the application module path.
>>
>> This came as a result from a comment on the PR of JDK-8339735.
>>
>> I included some minor wording on deploying as a module, with a link to `Service Loader's` _Developing Service Providers section_ to handle the heavy lifting. However, I am happy to adjust as needed, if it is felt that more info should be laid out directly on `CharsetProvider's` class description itself.
>>
>> An associated test is provided to confirm that a `CharsetProvider` _can_ be deployed as a module.
>
> Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>
> - resolve conflicts; list deployment as module first
> - merge master, resolve conflicts
> - reflect review comments
> - newline in module-info.java
> - init
src/java.base/share/classes/java/nio/charset/spi/CharsetProvider.java line 38:
> 36: * zero-argument constructor and some number of associated charset
> 37: * implementation classes. Charset providers may be installed in an instance
> 38: * of the Java platform as extensions. Providers may also be made available by
It is not related to module path, but taking this opportunity, let's amend this sentence that refers to "extensions" which is obsolete.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21076#discussion_r1767244764
More information about the nio-dev
mailing list