RFR: 8340404: Clarify CharsetProvider deployment on application module path [v3]

Justin Lu jlu at openjdk.org
Thu Sep 19 17:03:02 UTC 2024


On Thu, 19 Sep 2024 05:39:39 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - resolve conflicts; list deployment as module first
>>  - merge master, resolve conflicts
>>  - reflect review comments
>>  - newline in module-info.java
>>  - init
>
> test/jdk/java/nio/charset/spi/provider/module-info.java line 24:
> 
>> 22:  */
>> 23: module provider {
>> 24:     exports spi;
> 
> It's a bit of anti pattern for service provider modules to export an API, can you drop this? I don't think it's possible to check the test setup while that is there.

Thanks for taking a look Alan. Your test comments should be addressed in https://github.com/openjdk/jdk/pull/21076/commits/790abd039dd08ca1e0575feca29f681a2507d902.
Did you have any comments on the current doc change?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21076#discussion_r1767246756


More information about the nio-dev mailing list