RFR: 8340404: CharsetProvider specification updates [v6]

[Alan Bateman]

On Sat, 21 Sep 2024 18:13:12 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8340412) which clarifies that a CharsetProvider SPI can be provided via the application module path.
>> 
>> This came as a result from a comment on the PR of JDK-8339735. 
>> 
>> I included some minor wording on deploying as a module, with a link to `Service Loader's` _Developing Service Providers section_ to handle the heavy lifting. However, I am happy to adjust as needed, if it is felt that more info should be laid out directly on `CharsetProvider's` class description itself.
>> 
>> An associated test is provided to confirm that a `CharsetProvider` _can_ be deployed as a module.
>> 
>> Additionally some outdated info is corrected as part of this change.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review: spec correction - system class loader used, not context

src/java.base/share/classes/java/nio/charset/spi/CharsetProvider.java line 38:

> 36:  * zero-argument constructor and some number of associated {@code Charset}
> 37:  * implementation classes.  Charset providers are deployed by adding them to either
> 38:  * the application module path or the application class path. In order to be looked

The latest update to the class description looks quite good. I think this sentence can be simplified down to "Charset provider are deployed on the application module path ...".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21076#discussion_r1770051344