RFR: 8340404: CharsetProvider specification updates [v6]

Justin Lu jlu at openjdk.org
Mon Sep 23 18:42:38 UTC 2024


On Sun, 22 Sep 2024 07:48:03 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: spec correction - system class loader used, not context
>
> src/java.base/share/classes/java/nio/charset/spi/CharsetProvider.java line 38:
> 
>> 36:  * zero-argument constructor and some number of associated {@code Charset}
>> 37:  * implementation classes.  Charset providers are deployed by adding them to either
>> 38:  * the application module path or the application class path. In order to be looked
> 
> The latest update to the class description looks quite good. I think this sentence can be simplified down to "Charset provider are deployed on the application module path ...".

Thanks for the approval @AlanBateman . Could you also review the [CSR](https://bugs.openjdk.org/browse/JDK-8340412) when you get the chance.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21076#discussion_r1771916116


More information about the nio-dev mailing list