RFR: 8340404: CharsetProvider specification updates [v7]

Naoto Sato naoto at openjdk.org
Mon Sep 23 23:04:35 UTC 2024


On Mon, 23 Sep 2024 17:20:52 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8340412) which clarifies that a CharsetProvider SPI can be provided via the application module path.
>> 
>> This came as a result from a comment on the PR of JDK-8339735. 
>> 
>> I included some minor wording on deploying as a module, with a link to `Service Loader's` _Developing Service Providers section_ to handle the heavy lifting. However, I am happy to adjust as needed, if it is felt that more info should be laid out directly on `CharsetProvider's` class description itself.
>> 
>> An associated test is provided to confirm that a `CharsetProvider` _can_ be deployed as a module.
>> 
>> Additionally some outdated info is corrected as part of this change.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review: simplify wording

Marked as reviewed by naoto (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21076#pullrequestreview-2323665232


More information about the nio-dev mailing list