RFR: JDK-8337974 - ChannelInputStream::skip can use splice (linux)

[Alan Bateman]

On Sat, 21 Sep 2024 15:47:05 GMT, Markus KARG <duke at openjdk.org> wrote:

> I will look into adding some JavaDocs to better express the behavior of the changed classes.

In addition to skip, the other methods that may be implemented with more than one read are the transferTo, readAllBytes, readNBytes, ... all methods added since JDK 1.0. It may be that Socket's class level description or the setSoTimeout method will need wording to say that it is implementation specific as to how the configured timeouts works with these methods. It may apply to the entire operation or ports of, tricky to word.

The issue of skip or any of the other methods throwing IllegalBlockingModeException can probably be confined to the Socket.getInputStream's API docs where it already documents this exception as possible when reading.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20489#issuecomment-2378612632