Integrated: 8340404: CharsetProvider specification updates

Justin Lu jlu at openjdk.org
Fri Sep 27 18:28:43 UTC 2024


On Thu, 19 Sep 2024 00:07:30 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8340412) which clarifies that a CharsetProvider SPI can be provided via the application module path.
> 
> This came as a result from a comment on the PR of JDK-8339735. 
> 
> I included some minor wording on deploying as a module, with a link to `Service Loader's` _Developing Service Providers section_ to handle the heavy lifting. However, I am happy to adjust as needed, if it is felt that more info should be laid out directly on `CharsetProvider's` class description itself.
> 
> An associated test is provided to confirm that a `CharsetProvider` _can_ be deployed as a module.
> 
> Additionally some outdated info is corrected as part of this change.

This pull request has now been integrated.

Changeset: 082125d6
Author:    Justin Lu <jlu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/082125d61e4b7e0fd53528c0271ca8be621f242b
Stats:     157 lines in 4 files changed: 143 ins; 1 del; 13 mod

8340404: CharsetProvider specification updates

Reviewed-by: alanb, naoto

-------------

PR: https://git.openjdk.org/jdk/pull/21076


More information about the nio-dev mailing list