RFR: 8355445: [java.nio] Use @requires tag instead of exiting based on "os.name" property value [v2]
Brian Burkhalter
bpb at openjdk.org
Fri Apr 25 16:16:10 UTC 2025
On Fri, 25 Apr 2025 16:08:18 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> test/jdk/java/nio/file/Files/StreamTest.java line 30:
>>
>>> 28: * @run testng StreamTest
>>> 29: * @summary Unit test for java.nio.file.Files methods that return a Stream
>>> 30: * @requires (os.family == "linux")
>>
>> Hello Brian, the changes to the rest of the tests in this PR look good to me. I think the change to this test is an oversight. This test class has several test methods and it's only the `testProcFile()` which requires to be run on Linux. Adding this `@requires` would mean that we will now skip running the rest of these test methods on other operating systems.
>
>> I think the change to this test is an oversight.
>
> @jaikiran You are correct. Thanks for catching this mistake. I will revert that change to `StreamTest`.
`StreamTest` change reverted in 87eafb1.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24861#discussion_r2060524177
More information about the nio-dev
mailing list