RFR: 8364213: (bf) Improve java/nio/Buffer/GetChars.java test comments [v4]
Brett Okken
duke at openjdk.org
Fri Aug 1 13:40:01 UTC 2025
On Tue, 29 Jul 2025 15:49:33 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Brett Okken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> whitespace
>
> test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 104:
>
>> 102: * <li>String - description of the test scenario</li>
>> 103: * </ul>
>> 104: */
>
> That helps a bit but I think we need to break up charBufferArguments into simpler/maintainable methods that have clear comments to document the test cases that they generate. Right now it's just way too hard to see what is tested and not tested.
@AlanBateman @RogerRiggs any thoughts on just keeping the "random" tests and removing the "static"?
As I started breaking the static tests up into simpler methods, they ended up looking like the "random" tests, just with fixed offsets instead of what `randomizeRange` is doing, which did not really seem all that valuable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26512#discussion_r2248015202
More information about the nio-dev
mailing list