RFR: 8154364: Files.isSameFile() throws NoSuchFileException with broken symbolic links [v3]
Brian Burkhalter
bpb at openjdk.org
Thu Aug 14 19:00:12 UTC 2025
On Thu, 14 Aug 2025 16:15:00 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8154364: Propagate change of previous commit to Windows
>
> src/java.base/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java line 435:
>
>> 433: // check existence
>> 434: boolean exists1 = exists(obj1);
>> 435: boolean exists2 = exists(obj2);
>
> exists does the openForReadAttributeAccess+readAttributes+CloseHandle so it looks like the change means it will do it twice for each file.
Right, the Windows implementation is not good and needs to be rethought.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26736#discussion_r2277483808
More information about the nio-dev
mailing list