RFR: 8154364: (fs) Files.isSameFile() throws NoSuchFileException with broken symbolic links [v10]
Alan Bateman
alanb at openjdk.org
Wed Aug 20 13:11:42 UTC 2025
On Tue, 19 Aug 2025 18:15:02 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> This request proposes to broaden the definition of which paths are considered to be the same by `java.nio.file.Files.isSameFile()`. A new test is added to cover many comparisons.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8154364: Suggested change for key comparison
Latest implementation changes looks okay. I see there is a follow-up issue created to improve the 2-arg getIfExists.
I skimmed over IsSameFile and it looks like good coverage. I don't have cycles to walk through every line right now, hopefully others can help on that.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26736#pullrequestreview-3136528211
More information about the nio-dev
mailing list