RFR: 8360025: (se) Convert kqueue Selector Implementation to use FFM APIs [v2]
Alan Bateman
alanb at openjdk.org
Thu Aug 28 14:01:47 UTC 2025
On Tue, 19 Aug 2025 13:20:17 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:
>> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
>>
>> implementing feedback, adding missing errno checks, cleanup
>
> I made a few changes mostly based on comments but I'll give a little patch notes:
>
> - I'd missed some errno checks for kqueue
> - Moved the FFMUtils class from shared to just be in `maxosx`, I also changed how this gets the valueLayouts for C values to match how newer versions of jextract generate this
> - I changed how the util method that converts errno codes to their respective error strings
>
>
> I ran this against the selector tests on all OSs and everything seems green after repeated tests
@DarraghClarke @minborg Would it be possible to provide a brief summary on what modifications have been done to the jextract-generated classes? The use of FFMUtils jumps out. Ideally they would be checked in without modification as it makes it easy to re-generate. It might be that this never happens but there is something a bit uncomfortable about checking in modified sources.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25546#issuecomment-3233618089
More information about the nio-dev
mailing list