RFR: 8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException

[Daniel Fuchs]

On Tue, 9 Dec 2025 14:36:11 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which removes the testng specific timeout from a test method? 
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8255463, the `test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java` fails intermittently with:
> 
> 
> test InheritedChannelTest.test("StateTest", java.util.ImmutableCollections$List12 at d28f210): failure [30001ms]
> org.testng.internal.thread.ThreadTimeoutException: Method InheritedChannelTest.test() didn't finish within the time-out 30000
> 
> With the proposed change in this PR, it now relies on jtreg test timeout (default of 120 seconds). If the test continues to timeout for whatever reason, then jtreg will be able to capture the relevant thread dumps of the incomplete process (launched in this test method) to help debug the issue.
> 
> The existing 30 second timeout on the test method doesn't play any role in what the test verifies, so removing it doesn't change that verification.

Looks trivial to me.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28721#pullrequestreview-3557997566