RFR: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 [v2]

[Jaikiran Pai]

On Tue, 7 Jan 2025 23:23:53 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Modify the test to expect the same content types on Windows Server 2025 as it does on Windows 11.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8346671: Improve OS name test; use StaticProperty

Marked as reviewed by jpai (Reviewer).

test/jdk/java/nio/file/Files/probeContentType/Basic.java line 195:

> 193:         // Windows Server 2025
> 194:         if (OperatingSystem.isWindows() &&
> 195:             (StaticProperty.osName().matches("^.*[11|2025]$") ||

Hello Brian, the change looks reasonable to me. If we want to be extra "strict" on which Windows version this conditional is applicable for, then maybe we should include the regex pattern for one or more whitespace before the the `[11|2025]`. But given what this test is for, I think it's fine in this proposed form too.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22957#pullrequestreview-2535653987
PR Review Comment: https://git.openjdk.org/jdk/pull/22957#discussion_r1906218076