RFR: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk [v2]

Volkan Yazıcı duke at openjdk.org
Mon Jan 13 07:58:57 UTC 2025


On Fri, 10 Jan 2025 16:15:59 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify and document changes in `LoopingTruncate`
>
> test/jdk/java/nio/channels/FileChannel/LoopingTruncate.java line 52:
> 
>> 50:     public static void main(String[] args) throws Throwable {
>> 51:         Path path = Files.createTempFile(
>> 52:                 // Intentionally opting out from the default `java.io.tmpdir`.
> 
> A comment within the parameter list seems a bit weird as does the indentation.

I chose this style since the comment applies to a single argument and is only relevant within `createTempFile()`. Reverted to the old style in 909572e56d87d6a1411c2dba23cfd4c75eaa52ae.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23011#discussion_r1912787403


More information about the nio-dev mailing list