RFR: 8344943: Mark not subclassable classes final in java.base exported classes

[Eirik Bjørsnøs]

On Tue, 26 Nov 2024 18:55:50 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 1318:
>> 
>>> 1316:                      Version version,
>>> 1317:                      Set<Modifier> modifiers,
>>> 1318:                      Set<Requires> requires,
>> 
>> I assume you'll fix the alignment if this goes ahead.
>
> Thanks! Yes, that's good feedback. There are some non-API changes that I'd like to make, such as this and updating the comment for the `InterfaceAddress` constructor.
> 
> I prefered to make the initial PR draft contain just the CSR changes, such that PR would be useful and clean as a Specification change, since the diff is a bit noisy.
> 
> I'll keep your review comment here unresolved for now and get back to it pending CSR approval.

For the record:

It was not completely clear to me whether restricting these two package-private constructors to private is considered a specification change in the CSR sense. I opted to point them out in the CSR, just to make the change abundantly clear.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22389#discussion_r1859098445