RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v8]
Aleksey Shipilev
shade at openjdk.org
Thu Jan 23 08:51:40 UTC 2025
On Wed, 22 Jan 2025 23:44:02 GMT, Brent Christian <bchristi at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Alan's review
>
> src/java.base/share/classes/java/nio/BufferCleaner.java line 31:
>
>> 29: import java.lang.ref.Cleaner.Cleanable;
>> 30:
>> 31: class BufferCleaner {
>
> It looks like `BufferCleaner` is not meant to be instantiated. A private constructor (that throws?) would make that clear.
Correct, added some comments too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22165#discussion_r1926586462
More information about the nio-dev
mailing list