RFR: 8361715: (bf) Improve java/nio/Buffer/GetChars.java and migrate to JUnit
Brett Okken
duke at openjdk.org
Mon Jul 14 12:43:34 UTC 2025
On Mon, 14 Jul 2025 04:52:25 GMT, Chen Liang <liach at openjdk.org> wrote:
>> junit for CharSequence behavior of CharBuffer covering different CharBuffer implementations in various states (offset, position, limit)
>
> Unfortunately JDK guide asks to keep line ending as-is for git config, which makes fixing line ending problems easier if they exist, but make it harder to create new files with correct LF line endings on Windows.
>
> Also one question about this static final List in class: Is this done from a performance POV? I usually just build the stream or list of arguments in the static factory method.
@liach line endings have been fixed.
The static list was from POV of performance, but it is not all that expensive to recreate each time, if that is preferred.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26282#issuecomment-3069269662
More information about the nio-dev
mailing list