RFR: 8362581: Timeouts in java/nio/channels/SocketChannel/OpenLeak.java on UNIX [v2]

Jaikiran Pai jpai at openjdk.org
Fri Jul 25 14:53:55 UTC 2025


On Fri, 25 Jul 2025 14:26:39 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Hi,
>> 
>> This is a fix for 8362581 caused by the implementation for https://bugs.openjdk.org/browse/JDK-8348986
>> An incorrect check was added to the method Exceptions.ioException() which wasn't noticed partly
>> because that file was renamed, and webrev doesn't show the diffs side by side.
>> The effect of this change is to restore the method to pretty much what it was before, but taking account
>> of the changed categorisation of exceptions.
>> 
>> A test is not included since this was caught by an existing regression test.
>> 
>> Thanks,
>> Michael
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert test change

This looks good to me. I've verified that with this change, the timing for the test methods in `test/jdk/java/nio/channels/SocketChannel/OpenLeak.java` drops back to the same duration that was there before the changes that were done in https://bugs.openjdk.org/browse/JDK-8348986

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26478#pullrequestreview-3055757642


More information about the nio-dev mailing list