RFR: 8361715: (bf) Improve java/nio/Buffer/GetChars.java and migrate to JUnit [v10]

[Roger Riggs]

On Sat, 19 Jul 2025 16:18:53 GMT, Brett Okken <duke at openjdk.org> wrote:

>> junit for CharSequence behavior of CharBuffer covering different CharBuffer implementations in various states (offset, position, limit)
>
> Brett Okken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   name the parameterized tests

Looks good, a few comments.

test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 43:

> 41: 
> 42: /*
> 43:  * @test

The @bug should be copied from the original and the bugid that prompted the additions should be added.

test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 47:

> 45:  * @library /test/lib
> 46:  * @build jdk.test.lib.RandomFactory
> 47:  * @summary tests the CharBuffer implementations behaving as CharSequence in various states (postion, limit, offset)

typo: "postion" -> "position"

test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 113:

> 111:         String stringBuf = new String(buf);
> 112: 
> 113:         for (int i = 0; i < 29; i += 7) {

Some description of why 29 and 7 would be useful.
Ditto, 1273 above, big but not too big?

-------------

PR Review: https://git.openjdk.org/jdk/pull/26282#pullrequestreview-3055904668
PR Review Comment: https://git.openjdk.org/jdk/pull/26282#discussion_r2231421176
PR Review Comment: https://git.openjdk.org/jdk/pull/26282#discussion_r2231417687
PR Review Comment: https://git.openjdk.org/jdk/pull/26282#discussion_r2231454388