RFR: 8361715: (bf) Improve java/nio/Buffer/GetChars.java and migrate to JUnit [v11]

[Brett Okken]

On Mon, 28 Jul 2025 14:05:19 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brett Okken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   code review comments
>
> test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 93:
> 
>> 91:     }
>> 92: 
>> 93:     static List<Arguments> charBufferArguments() {
> 
> This needs a clear comment to say what it returns, or maybe we should split it so we have more than one method source.

Would something like this work:


    /**
     * Returns a {@code List} of {@link Arguments}, with each entry representing a test case scenario.
     * <ul>
     * <li>CharBuffer - the instance to be tested</li>
     * <li>char[] - the data expected to be backing the current state of the CharBuffer</li>
     * <li>int start - index (inclusive) into char[] where the CharBuffer should be positioned</li>
     * <li>int stop - index (exclusive) into char[] where the CharBuffer should be limited</li>
     * <li>String - description of the test scenario</li>
     * </ul>
     */

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26282#discussion_r2236807417