RFR: 8364213: (bf) Improve java/nio/Buffer/GetChars.java test comments [v2]
Roger Riggs
rriggs at openjdk.org
Wed Jul 30 15:53:58 UTC 2025
On Wed, 30 Jul 2025 15:06:38 GMT, Brett Okken <duke at openjdk.org> wrote:
>> Address code review comments which came in post integration/merge of https://github.com/openjdk/jdk/pull/26282.
>>
>> Update/clarify test summary tag
>> Document the values generated for arguments
>> Move the endian-ness qualifier in the test descriptor string to not be first
>> Change test method names to more closely match arg names of method under test
>
> Brett Okken has updated the pull request incrementally with two additional commits since the last revision:
>
> - whitespace
> - better documentation for "random" test cases
>
> fix for random range generation (JDK-8364345)
test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 77:
> 75:
> 76: /**
> 77: * Generates random content to use for populating <i>cb</i> then calling through to {@code addCases(String, char[], CharBuffer, List)}
Try to keep the line lengths under 100 chars (80 is better).
It makes it possible to do size-by-size reviews that some reviewers prefer.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26512#discussion_r2243145495
More information about the nio-dev
mailing list