RFR: 8358537: (bf) JavaNioAccess::getBufferAddress bypasses direct buffer MemorySession state check [v2]
Alan Bateman
alanb at openjdk.org
Thu Jun 5 10:09:52 UTC 2025
On Wed, 4 Jun 2025 22:10:26 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
> Perhaps some comments need to be added in strategic places to clarify the situation to avoid similar confusion in the future?
I think we should start by reviewing the test coverage. The channels/etc/MemorySegments.java test that we added will exercise all the methods on the synchronous channels that take a ByteBuffer as a parameter. We need to check what tests we have for AsynchronousSocketChannel and AsynchronousFileChannel to ensure that we are testing them with buffers that are views of memory segments allocated from an auto or the global arena. We need good tests before changing anything.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25631#issuecomment-2943562745
More information about the nio-dev
mailing list