RFR: 8357959: (bf) ByteBuffer.allocateDirect initialization can result in large TTSP spikes [v8]
Rohitash Kumar
duke at openjdk.org
Tue Jun 10 16:27:52 UTC 2025
On Tue, 10 Jun 2025 15:47:14 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Rohitash Kumar has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - rename param from size to count
>> - Apply patch for test extension
>
> test/jdk/java/nio/Buffer/AllocateDirectInit.java line 70:
>
>> 68:
>> 69: private static void check(ByteBuffer bb) {
>> 70: for (bb.position(0); bb.position() < bb.limit(); ) {
>
> I think it would be more readable to use `while (bb.hasRemaining()) {` here.
>
> Also can you update the end date in the copyright header.
Done 👍
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25487#discussion_r2138324258
More information about the nio-dev
mailing list