RFR: 8332623: Remove setTTL()/getTTL() methods from DatagramSocketImpl/MulticastSocket and MulticastSocket.send(DatagramPacket, byte) [v3]

[Jaikiran Pai]

On Wed, 11 Jun 2025 11:49:22 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Daniel's review - continue to test MulticastSocket in SendCheck
>
> test/jdk/java/net/DatagramSocket/SendCheck.java line 133:
> 
>> 131: 
>> 132:         List<Object[]> testcases = new ArrayList<>();
>> 133:         for (var packet : Packets) {
> 
> Should we instead just remove the ttl parameter and test with plain MulticastSocket::send?

That's a good catch. The test description of this test states that it's meant to test DatagramSocket, the adaptor, the DatagramChannel and the MulticastSocket. The change I did would have stopped testing MulticastSocket altogether. I have now updated the PR to only remove the use of a setTTL() from this test and it now continues to test the send() methods of these classes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25744#discussion_r2139961400