RFR: 8360887: (fs) Files.getFileAttributeView returns unusable FileAttributeView if UserDefinedFileAttributeView unavailable (aix) [v2]

Martin Doerr mdoerr at openjdk.org
Mon Jun 30 13:00:21 UTC 2025


On Mon, 30 Jun 2025 10:02:32 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update Copyright years.
>>  - Add bug id to test.
>
> test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java line 288:
> 
>> 286:                 if (Files.getFileAttributeView(dir, UserDefinedFileAttributeView.class) != null) {
>> 287:                     throw new RuntimeException("UserDefinedFileAttributeView not supported, getFileAttributeView should return null");
>> 288:                 }
> 
> This is the test for UserDefinedFileAttributeView, it's not meant to be a test for the FileSystemProvider. getFileAttributeView methods. So I think we need to see if there is an existing test that should be updated, or maybe a new test will need to be added.

I've moved it. Please take a look.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26021#discussion_r2175010825


More information about the nio-dev mailing list