RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v2]

Markus KARG duke at openjdk.org
Mon Mar 24 11:55:28 UTC 2025


On Mon, 24 Mar 2025 11:38:58 GMT, Markus KARG <duke at openjdk.org> wrote:

>> src/java.base/share/classes/java/nio/X-Buffer.java.template line 1911:
>> 
>>> 1909:      * @implNote This method allows for superior performance over the default
>>> 1910:      * implementation in {@code CharSequence}. It performs a direct
>>> 1911:      * buffer-to-array copy of the complete specified region.
>> 
>> I think the API and implementation notes are redundant.
>
> Do you think? The `implNote` here explains that it *actually* provides superior performance, while that API notes do say nothing about *actual* implementation. Anyways, I have no strong feelings. Shall I remomve it? 🤔

Fixed in https://github.com/openjdk/jdk/pull/21730/commits/d27d1bd85458f02e859a9653805d96ff79473124

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21730#discussion_r2010027530


More information about the nio-dev mailing list