RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v3]
Jaikiran Pai
jpai at openjdk.org
Mon May 5 14:18:26 UTC 2025
On Mon, 5 May 2025 14:00:39 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> reword SocketImpl.create(...) API doc
>
> src/java.base/share/classes/java/net/SocketImpl.java line 90:
>
>> 88: * <p>
>> 89: * This method will be re-specified in a future release to not
>> 90: * support creating datagram sockets.
>
> I think this could do with another round of rewording. I think I would say that the "stream" parameter provided a way in early JDK releases to create a Socket that used a datagram socket. It's no longer possible to do this and therefore this method will only be called by Socket with stream == false.
I pushed a change to take these suggestions. I did some minor changes to the wording. Do you recommend any further changes to that text?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25031#discussion_r2073536109
More information about the nio-dev
mailing list