RFR: 8353795: Add Writer.of(StringBuilder) [v2]

Jesper Wilhelmsson jwilhelm at openjdk.org
Tue May 6 21:57:15 UTC 2025


On Sun, 4 May 2025 16:21:41 GMT, Markus KARG <duke at openjdk.org> wrote:

>> This Pull Requests proposes an implementation for [JDK-8353795](https://bugs.openjdk.org/browse/JDK-8353795): Adding the new method `public static Writer Writer.of(StringBuilder)`, providing a non-synchronized Writer implementation optimized for writing into `StringBuilder`.
>> 
>> A basic test is provided to proof that the new `Writer` behaves as expected. For comparison, the same test is also run against `StringWriter`.
>
> Markus KARG has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Undone copyright update of otherwise unchanged file.
>  - Update Of.java
>    
>    Applied changnes proposed by @liach: "the default toString already includes id=..., so I usually don't provide an explicit override to make the code concise."

We must remember that the OpenJDK community is built by individuals with different backgrounds and motivations to engaging. Some people get paid to work on OpenJDK development, others do it in their own time. It would be next to impossible to dictate any kinds of rules to enforce engagement from reviewers as this would require companies and individuals to commit to prioritizing issues that may not be in their interest to spend time on.

Any kind of "if you engage in a discussion you must reply within X weeks" will most likely only result in less people engaging in the first place.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24469#issuecomment-2856187951


More information about the nio-dev mailing list