Integrated: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer
Markus KARG
duke at openjdk.org
Thu May 8 01:01:06 UTC 2025
On Sat, 26 Oct 2024 15:48:11 GMT, Markus KARG <duke at openjdk.org> wrote:
> This Pull Request proposes an implementation for [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new method `public void getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)` to the `CharSequence` interface, providing a **bulk-read** facility including a default implementation iterating over `charAt(int)`.
>
> In addition, this Pull Request proposes to replace the implementation of `Reader.of(CharSequence).read(char[] cbuf, int off, int len)` to invoke `CharSequence.getChars(next, next + n, cbuf, off)` instead of utilizing pattern matching for switch. Also, this PR proposes to implement `CharBuffer.getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)` as an alias for `CharBuffer.get(srcBegin, dst, dstBegin, srcEnd - srcBegin)`.
>
> To ensure quality...
> * ...the method signature and JavaDocs are adapted from `AbstractStringBuilder.getChars(...)`.
> * ...this PR relies upon the existing tests for `Reader.of(CharSequence)`, as these provide sufficient coverage of all changes introduced by this PR.
This pull request has now been integrated.
Changeset: 7642556a
Author: Markus KARG <markus at headcrashing.eu>
Committer: Jaikiran Pai <jpai at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/7642556a5a131e9104033ad7d7abfdb4be5012cf
Stats: 470 lines in 8 files changed: 399 ins; 59 del; 12 mod
8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer
Reviewed-by: liach, jpai, rriggs
-------------
PR: https://git.openjdk.org/jdk/pull/21730
More information about the nio-dev
mailing list