RFR: 8356127: (fs) UnixFileSystemProvider.implDelete could save a syscall in some cases [v2]

Fri May 9 06:22:53 UTC 2025

On Thu, 8 May 2025 20:06:49 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java line 552:
>> 
>>> 550:      */
>>> 551:     static boolean eisdirSupported() {
>>> 552:         return (capabilities & SUPPORTS_EISDIR) != 0;
>> 
>> The approach in this version looks much better. Need to find a better name for the capability and method name as "EISDIR" is supported on all Unix/like platforms. I think we want something to convey unlink detects directories or fails for directories.
>
> Naming updated in [3814a18](https://github.com/openjdk/jdk/pull/25107/commits/3814a184551496b01d9f0f44a514c23aa1e094b7).

Updated name looks okay, thanks for adjusting that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25107#discussion_r2081008799