RFR: 8356606: (fs) PosixFileAttributes.permissions() implementations should return an EnumSet

Alan Bateman alanb at openjdk.org
Sat May 10 06:22:54 UTC 2025


On Fri, 9 May 2025 22:48:11 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> Drop-in replacement in `sun.nio.fs.UnixFileAttributes::permissions` of `HashSet` with `EnumSet` for hopefully improved efficiency. All tests containing `PosixFileAttributes` passed.

I assume reading POSIX file permissions is going to be dominated by stat/equivalent, it might be that the JBS issue was more of a suggestion from someone reading the code?

In any case, it looks fine and I assume you'll run the jdk_nio tests.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25162#pullrequestreview-2830393769


More information about the nio-dev mailing list