RFR: 8350880: (zipfs) Add support for read-only zip file systems [v3]
David Beaumont
duke at openjdk.org
Mon May 12 10:21:50 UTC 2025
On Mon, 12 May 2025 10:16:33 GMT, David Beaumont <duke at openjdk.org> wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite values, and ensures that the requested mode is consistent with what's returned.
>>
>> This involved a little refactoring to ensure that "read only" state was set initially and only unset at the end of initialization if appropriate.
>>
>> By making 2 methods return values (rather than silently set non-final fields as a side effect) it's now clear in what order fields are initialized and which are final (sadly there are still non-final fields, but only a split of this class into two types can fix that, since determining multi-jar support requires reading the file system).
>
> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix comment based on current behaviour.
Obvious mistakes now fixed (it's amazing what you only spot when looking at code in a review UI).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25178#issuecomment-2871935949
More information about the nio-dev
mailing list