RFR: 8354530: AIX: sporadic unexpected errno when calling setsockopt in Net.joinOrDrop [v2]
Arno Zeller
azeller at openjdk.org
Wed May 14 19:01:52 UTC 2025
On Wed, 14 May 2025 13:32:03 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Arno Zeller has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improve comment.
>
> src/java.base/unix/native/libnio/ch/Net.c line 683:
>
>> 681: }
>> 682: }
>> 683: #endif
>
> drive-by comment, would it not make sense to then wait some milliseconds before the next try?
I am unsure if this would be better - I have seen test failing about 2-3 times a day in our nightly tests. With a direct retry I have seen tests failing only every 3-5 days - with a second retry it failed only one time in 3 weeks. Therefore I decided to go for 3 retries without waiting.
Another possibility would be to wait for an increasing number of milliseconds - like 0, 10, 20ms in each try. But I am not sure if this is worth it.
What do you think?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24996#discussion_r2089555110
More information about the nio-dev
mailing list