RFR: 8356888: (fs) FileSystems.newFileSystem that take an env must specify IllegalArgumentException
Lance Andersen
lancea at openjdk.org
Thu May 22 12:44:53 UTC 2025
On Thu, 22 May 2025 00:13:57 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
> Add a throws clause for `IllegalArgumentException` to the `java.nio.file.FileSystems` methods `newFileSystem(Path, Map)` and `newFileSystem(Path, Map, ClassLoader)`. Also update the equivalent IAE verbiage for the analogous methods which accept a `URI` parameter instead of a `Path`.
Hi Brian,
Thanks for adding the IAE to the javadoc for these methods which I missed when I added these.
overall looks good
One minor missing update is that we should add `@since 13` to
`public static FileSystem newFileSystem(Path path, ClassLoader loader)`
Which I added as part of the additions of these methods
-------------
Changes requested by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25376#pullrequestreview-2861075801
More information about the nio-dev
mailing list