RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v8]

Per Minborg pminborg at openjdk.org
Tue May 27 11:23:55 UTC 2025


On Mon, 26 May 2025 16:05:13 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address comments
>
> src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java line 669:
> 
>> 667: 
>> 668:             } finally {
>> 669:                 IOUtil.releaseScope(buf);
> 
> I don't think we can release here when there is an I/O pending. I suspect it will need to go into releaseBufferIfSubstituted. 
> 
> TBH, I think the change to Windows implementation of AsynchronousFileChannel are going to take more eyes and significant testing. What would you think about dropping it from this PR and creating a separate JBS issue as this is going to require more cycles that everything else in this PR.

Sounds like a good idea: https://bugs.openjdk.org/browse/JDK-8357847

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25324#discussion_r2108922601


More information about the nio-dev mailing list