RFR: 8356977: UTF-8 cleanups [v2]
Naoto Sato
naoto at openjdk.org
Tue May 27 16:37:56 UTC 2025
On Mon, 26 May 2025 07:44:30 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> test/jdk/sun/text/resources/LocaleDataTest.java line 106:
>>
>>> 104: * FormatData/fr_FR/MonthNames/0=janvier
>>> 105: * FormatData/fr_FR/MonthNames/1=février
>>> 106: * LocaleNames/fr_FR/US=États-Unis
>>
>> This test data (LocaleData.cldr) is explicitly encoded in ISO-8859-1 with unicode escapes for characters outside of it. So only changing these ones in comment does not seem correct.
>
> ISO-8859-1 does not sound good, and got me worried. But in fact it seems like the file is pure ASCII, and that is fine.
>
> However, if the file should ever be changed to include actual ISO-8859-1 encoding, this might break if tools assume it is UTF-8-encoding, since not all ISO-8859-1 encodings are valid UTF-8.
Thanks. Filed an issue to change the encoding in the test to UTF-8: https://bugs.openjdk.org/browse/JDK-8357882
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25228#discussion_r2109668481
More information about the nio-dev
mailing list