RFR: 8348986: Improve coverage of enhanced exception messages [v11]

[Michael McMahon]

On Mon, 26 May 2025 17:07:45 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 28 commits:
>> 
>>  - Merge branch 'master' into 8348986-exceptions
>>  - update
>>  - reduced number of new categories
>>  - Merge branch 'master' into 8348986-exceptions
>>  - Merge branch 'master' into 8348986-exceptions
>>  - Merge branch 'master' into 8348986-exceptions
>>  - Merge branch 'master' into 8348986-exceptions
>>  - Review update
>>  - review update
>>  - Merge branch 'master' into 8348986-exceptions
>>  - ... and 18 more: https://git.openjdk.org/jdk/compare/e961b13c...cc518c19
>
> src/java.base/share/classes/jdk/internal/util/Exceptions.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights reserved.
> 
> new file => copyright ?
> 
> Copyright (c) 2025,

The file isn't actually new, though webrev doesn't seem to realise that on this occasion (sometimes it does recognise name changes). It was previously named SocketExceptions. I presume we keep the existing header in that case?

> src/java.base/share/classes/jdk/internal/util/Exceptions.java line 130:
> 
>> 128:         public abstract String output();
>> 129: 
>> 130:         protected String output(boolean enhance) {
> 
> to help us simple folk getting into a tizzy over a public abstract and a protected method of the same name and overloaded to boot
> suggest
> refactor rename this method name to composeFilteredMessageText  or composeFilteredText or just compose

Okay, I'll use one of those options, whichever fits best space wise.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23929#discussion_r2111618040
PR Review Comment: https://git.openjdk.org/jdk/pull/23929#discussion_r2111620553