RFR: 8348986: Improve coverage of enhanced exception messages [v11]

Michael McMahon michaelm at openjdk.org
Wed May 28 11:38:01 UTC 2025


On Mon, 26 May 2025 17:40:39 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 28 commits:
>> 
>>  - Merge branch 'master' into 8348986-exceptions
>>  - update
>>  - reduced number of new categories
>>  - Merge branch 'master' into 8348986-exceptions
>>  - Merge branch 'master' into 8348986-exceptions
>>  - Merge branch 'master' into 8348986-exceptions
>>  - Merge branch 'master' into 8348986-exceptions
>>  - Review update
>>  - review update
>>  - Merge branch 'master' into 8348986-exceptions
>>  - ... and 18 more: https://git.openjdk.org/jdk/compare/e961b13c...cc518c19
>
> src/java.base/share/classes/jdk/internal/util/Exceptions.java line 58:
> 
>> 56:  *     public static SensitiveInfo filterUserName(String name)
>> 57:  */
>> 58: public final class Exceptions {
> 
> maybe a refactor rename to convey some of the semantics of the class e.g. ExceptionMessageFilter

I see what you mean, but the class does more than just filter messages. It also generates new Exception objects from existing ones. Given that its original name was `SocketExceptions` and all we've done here is generalize it to work with other exception types, I think `Exceptions` is a reasonable name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23929#discussion_r2111626402


More information about the nio-dev mailing list