RFR: 8371689: (fs) CopyMoveHelper.copyToForeignTarget use of sourcePosixView is confusing [v3]

[Alan Bateman]

On Fri, 14 Nov 2025 17:25:34 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> In `CopyMoveHelper`, replace `PosixFileAttributeView` with a `boolean`.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8371689: Determine posix attributes support based on the view being retrievable

This update looks okay.

src/java.base/share/classes/java/nio/file/CopyMoveHelper.java line 122:

> 120:                                                PosixFileAttributes.class,
> 121:                                                linkOptions);
> 122:         if (sourceAttrs == null)

This could if-then-else too.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28304#pullrequestreview-3466137361
PR Review Comment: https://git.openjdk.org/jdk/pull/28304#discussion_r2528456180