RFR: 8371697: test/jdk/java/nio/file/FileStore/Basic.java fails after 8360887 on linux [v6]
SendaoYan
syan at openjdk.org
Mon Nov 17 07:12:28 UTC 2025
On Mon, 17 Nov 2025 06:53:13 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add the comment
>
> test/jdk/java/nio/file/FileStore/Basic.java line 80:
>
>> 78: // in these views may not supported on all FileStores.
>> 79: // So we only check for non-null view if the store supports the view.
>> 80: if (supported) {
>
> I would prefer if the comment said something like "If the view is supported by the FileStore then Files.getFileAttributeView should return return that view".
Thanks, the comment has been updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28281#discussion_r2532943332
More information about the nio-dev
mailing list