RFR: 8371697: test/jdk/java/nio/file/FileStore/Basic.java fails after 8360887 on linux [v8]

[Alan Bateman]

On Mon, 17 Nov 2025 07:21:43 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> The new method testFileAttributes in test/jdk/java/nio/file/FileStore/Basic.java added by [JDK-8360887](https://bugs.openjdk.org/browse/JDK-8360887)/[JDK-8361183](https://bugs.openjdk.org/browse/JDK-8361183) fails on some linux machines. A FileSystemProvider may support many views but some of these attributes in these views may not supported on all FileStores.
>> 
>> Change has been verified locally on linux-aarch64.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Asserts.assertTrue instead of Asserts.assertNotNull

I should have been clearer in my comments. If this test is changed to jdk.test.lib.Asserts then I think we should remove the local assertTrue method. The simplest is to just `import static jdk.test.lib.Asserts.*` and remove the local assertTrue method, it should just work.  The assertNotNull in the previous iteration was good, and better than assertTrue as you get a better diagnostic in the event of a failure.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28281#issuecomment-3540336641