RFR: 8371697: test/jdk/java/nio/file/FileStore/Basic.java fails after 8360887 on linux [v8]

SendaoYan syan at openjdk.org
Tue Nov 18 03:21:40 UTC 2025


On Mon, 17 Nov 2025 07:30:16 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Asserts.assertTrue instead of Asserts.assertNotNull
>
> I should have been clearer in my comments. If this test is changed to jdk.test.lib.Asserts then I think we should remove the local assertTrue method. The simplest is to just `import static jdk.test.lib.Asserts.*` and remove the local assertTrue method, it should just work.  The assertNotNull in the previous iteration was good, and better than assertTrue as you get a better diagnostic in the event of a failure.

Thanks for the suggestions and reviews @AlanBateman

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28281#issuecomment-3544846643


More information about the nio-dev mailing list