From bpb at openjdk.org  Wed Oct  1 16:43:10 2025
From: bpb at openjdk.org (Brian Burkhalter)
Date: Wed, 1 Oct 2025 16:43:10 GMT
Subject: RFR: 8337143: (fc, fs) Move filesystem-related native objects from
 libnio to libjava [v16]
In-Reply-To: <TNlAuJBeBcTH1PE3w2bgVm-OFNoQcN84ICcym6yX3hs=.b134d04f-caff-49bf-87f1-de893bbcd6ef@github.com>
References: <TNlAuJBeBcTH1PE3w2bgVm-OFNoQcN84ICcym6yX3hs=.b134d04f-caff-49bf-87f1-de893bbcd6ef@github.com>
Message-ID: <zpsaCrgZQIHZY-HAlSFxruwk13dsLxEYhgl2Aj7zTdE=.4da22ba3-8893-44ed-b61c-2f689b1e47f7@github.com>

> This proposed change would move the native objects required for NIO file interaction from the libnio native library to the libjava native library on Linux, macOS, and Windows.

Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:

 - Merge
 - Merge
 - Merge
 - Merge
 - Merge
 - Merge
 - Merge
 - Merge
 - 8337143: Minor makefile tweak
 - 8337143: Clean up to address reviewer comments
 - ... and 6 more: https://git.openjdk.org/jdk/compare/fe9dbcc4...498be60b

-------------

Changes: https://git.openjdk.org/jdk/pull/20317/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20317&range=15
  Stats: 1539 lines in 92 files changed: 774 ins; 668 del; 97 mod
  Patch: https://git.openjdk.org/jdk/pull/20317.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20317/head:pull/20317

PR: https://git.openjdk.org/jdk/pull/20317

From naoto at openjdk.org  Wed Oct  1 20:01:58 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 1 Oct 2025 20:01:58 GMT
Subject: RFR: 8368845: x-IBM930 uses incorrect character for Hex 42 60
Message-ID: <0Ep8UN3_bJ-nR9RCNIUaRA7flGGV3khNSjstui2ijRk=.d3eb41c7-1bae-4916-9c80-876d5912724f@github.com>

Fixing a charset en/decoder for x-IBM930. There was a "temporary" mapping for the said code point for the backward compatibility (as of  JDK7). Since the issue requests the "correct" mapping, I believe we can replace the temporary one with the correct mapping.

-------------

Commit messages:
 - initial commit

Changes: https://git.openjdk.org/jdk/pull/27594/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=27594&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8368845
  Stats: 15 lines in 3 files changed: 0 ins; 13 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/27594.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27594/head:pull/27594

PR: https://git.openjdk.org/jdk/pull/27594

From jlu at openjdk.org  Wed Oct  1 20:43:05 2025
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 1 Oct 2025 20:43:05 GMT
Subject: RFR: 8368845: x-IBM930 uses incorrect character for Hex 42 60
In-Reply-To: <0Ep8UN3_bJ-nR9RCNIUaRA7flGGV3khNSjstui2ijRk=.d3eb41c7-1bae-4916-9c80-876d5912724f@github.com>
References: <0Ep8UN3_bJ-nR9RCNIUaRA7flGGV3khNSjstui2ijRk=.d3eb41c7-1bae-4916-9c80-876d5912724f@github.com>
Message-ID: <x0h0evhRGPTuUs4d7-0AUo-sv-jIdHRs2mo38TOic8A=.b97b2d13-905d-40b9-bfaf-c72eb685794a@github.com>

On Wed, 1 Oct 2025 19:50:49 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a charset en/decoder for x-IBM930. There was a "temporary" mapping for the said code point for the backward compatibility (as of  JDK7). Since the issue requests the "correct" mapping, I believe we can replace the temporary one with the correct mapping.

Should we add a test to confirm the swap to the new behavior?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27594#issuecomment-3358062301

From naoto at openjdk.org  Wed Oct  1 21:06:19 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 1 Oct 2025 21:06:19 GMT
Subject: RFR: 8368845: x-IBM930 uses incorrect character for Hex 42 60 [v2]
In-Reply-To: <0Ep8UN3_bJ-nR9RCNIUaRA7flGGV3khNSjstui2ijRk=.d3eb41c7-1bae-4916-9c80-876d5912724f@github.com>
References: <0Ep8UN3_bJ-nR9RCNIUaRA7flGGV3khNSjstui2ijRk=.d3eb41c7-1bae-4916-9c80-876d5912724f@github.com>
Message-ID: <llTRSwTVCz-s3m7L3It_i6d6lD2qy_4rUXURzeg1ciA=.7c08e484-d7a1-475b-92a0-848e165f515c@github.com>

> Fixing a charset en/decoder for x-IBM930. There was a "temporary" mapping for the said code point for the backward compatibility (as of  JDK7). Since the issue requests the "correct" mapping, I believe we can replace the temporary one with the correct mapping.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  added bugid to the tests

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/27594/files
  - new: https://git.openjdk.org/jdk/pull/27594/files/bd338444..30ba5ce5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=27594&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27594&range=00-01

  Stats: 7 lines in 3 files changed: 1 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/27594.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27594/head:pull/27594

PR: https://git.openjdk.org/jdk/pull/27594

From naoto at openjdk.org  Wed Oct  1 21:06:21 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 1 Oct 2025 21:06:21 GMT
Subject: RFR: 8368845: x-IBM930 uses incorrect character for Hex 42 60
In-Reply-To: <x0h0evhRGPTuUs4d7-0AUo-sv-jIdHRs2mo38TOic8A=.b97b2d13-905d-40b9-bfaf-c72eb685794a@github.com>
References: <0Ep8UN3_bJ-nR9RCNIUaRA7flGGV3khNSjstui2ijRk=.d3eb41c7-1bae-4916-9c80-876d5912724f@github.com>
 <x0h0evhRGPTuUs4d7-0AUo-sv-jIdHRs2mo38TOic8A=.b97b2d13-905d-40b9-bfaf-c72eb685794a@github.com>
Message-ID: <o5ddOBCL-Ur3tnO2AlalSoEOrnZk2CfPInzFD6KDFtA=.8f48b0ec-498d-4014-8d87-597bb46508bf@github.com>

On Wed, 1 Oct 2025 20:40:39 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Should we add a test to confirm the swap to the new behavior?

I had added the test data for the new mapping (Cp930.b2c) which is used for several test cases. Added the bug id to the relevant tests which should make it clearer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27594#issuecomment-3358124998