RFR: 8365626: (fs) Improve handling of broken links in Files.isSameFile() (win)

Alan Bateman alanb at openjdk.org
Fri Sep 5 13:15:11 UTC 2025


On Thu, 4 Sep 2025 00:30:52 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> Improve handling of broken symbolic links in `Files.isSameFile` on Windows as was done on Unix by the fix of [JDK-8154364](https://bugs.openjdk.org/browse/JDK-8154364).

src/java.base/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java line 462:

> 460:             handle = h;
> 461: 
> 462:             String target = WindowsLinkSupport.readLink(path);

If you add WindowsLinkSupport.readLink(handle) then it would avoid close the file, then re-opening it again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27079#discussion_r2325068094


More information about the nio-dev mailing list