RFR: 8365626: (fs) Improve handling of broken links in Files.isSameFile() (win) [v2]

Alan Bateman alanb at openjdk.org
Tue Sep 9 13:21:21 UTC 2025


On Tue, 9 Sep 2025 00:30:43 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Improve handling of broken symbolic links in `Files.isSameFile` on Windows as was done on Unix by the fix of [JDK-8154364](https://bugs.openjdk.org/browse/JDK-8154364).
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8365626: Incorporate suggestions from review comments

src/java.base/windows/classes/sun/nio/fs/WindowsLinkSupport.java line 96:

> 94:      * Returns the target of a symbolic link
> 95:      */
> 96:     static String readLink(WindowsPath path, long handle) throws IOException {

It might be better to rename readLinkImpl to readLink and make it non-public, maybe you've tried this already?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27079#discussion_r2333568800


More information about the nio-dev mailing list