RFR: 8365626: (fs) Improve handling of broken links in Files.isSameFile() (win) [v2]

Alan Bateman alanb at openjdk.org
Tue Sep 9 17:24:51 UTC 2025


On Tue, 9 Sep 2025 15:30:24 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/windows/classes/sun/nio/fs/WindowsLinkSupport.java line 96:
>> 
>>> 94:      * Returns the target of a symbolic link
>>> 95:      */
>>> 96:     static String readLink(WindowsPath path, long handle) throws IOException {
>> 
>> It might be better to rename readLinkImpl to readLink and make it non-public, maybe you've tried this already?
>
>> [...] rename readLinkImpl to readLink and make it non-public [...]
> 
> By "non-public" do you intend package scope?

Yes, so that the renamed readLinkImpl is accessible in the package.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27079#discussion_r2334294176


More information about the nio-dev mailing list