RFR: 8365626: (fs) Improve handling of broken links in Files.isSameFile() (win) [v4]

Alan Bateman alanb at openjdk.org
Thu Sep 11 09:05:05 UTC 2025


On Wed, 10 Sep 2025 22:31:13 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Improve handling of broken symbolic links in `Files.isSameFile` on Windows as was done on Unix by the fix of [JDK-8154364](https://bugs.openjdk.org/browse/JDK-8154364).
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8365626: Address reviewer comments since previous commit

src/java.base/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java line 483:

> 481:                 EntryAttributes linkAttr = new EntryAttributes(attrs, h);
> 482:                 if (!linkAttrs.add(linkAttr))
> 483:                     throw new FileSystemLoopException(path.toString());

Is this handle closed if FileSystemLoopException is thrown?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27079#discussion_r2339607503


More information about the nio-dev mailing list