RFR: 8365626: (fs) Improve handling of broken links in Files.isSameFile() (win) [v9]

Brian Burkhalter bpb at openjdk.org
Fri Sep 19 16:28:15 UTC 2025


On Fri, 19 Sep 2025 11:06:45 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8365626: Further cleanup
>
> src/java.base/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java line 451:
> 
>> 449:     /**
>> 450:      * Returns the attributes of the next symbolic link encountered in the
>> 451:      * specified path. The handle contained in the returned value must be closed
> 
> I assume the first sentence was copied from lastLinkAttributes whereas it should say that it returns the attributes of the file located by the given path if it's a symbolid link.

Fixed in [9b4d128](https://github.com/openjdk/jdk/pull/27079/commits/9b4d128cf00552f4032f91f1611738dbbf8133db).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27079#discussion_r2363532486


More information about the nio-dev mailing list