RFR: 8368156: java/nio/file/Files/IsSameFile.java failing (win) [v2]

[Brian Burkhalter]

On Tue, 23 Sep 2025 07:07:37 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8368156: Address reviewer comments
>
> test/jdk/java/nio/file/Files/IsSameFile.java line 28:
> 
>> 26:  * @summary Test of Files.isSameFile
>> 27:  * @library .. /test/lib
>> 28:  * @build IsSameFile jdk.test.lib.util.FileUtils
> 
> Test target is not necessary to be included in the `@build`:
> 
> Suggestion:
> 
>  * @build jdk.test.lib.util.FileUtils

Neither is `FileUtils`; both removed in 7ace52e.

> test/jdk/java/nio/file/Files/IsSameFile.java line 73:
> 
>> 71:     public void init() throws IOException {
>> 72:         Path cwd = Path.of(System.getProperty("user.dir"));
>> 73:         home = Files.createTempDirectory(cwd, "TestISameFile");
> 
> Suggestion:
> 
>         home = Files.createTempDirectory(cwd, "TestIsSameFile");
> 
> 
> You can also opt for `TestIsSameFile.class.getSimpleName()` to make the code IDE-refactoring-prone.

Changed as suggested in 7ace52e.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27440#discussion_r2372809268
PR Review Comment: https://git.openjdk.org/jdk/pull/27440#discussion_r2372808344